Skip to content

Version 2 kick off with docker support #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mkalish wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Version 2 kick off with docker support #168

mkalish wants to merge 2 commits into from

Conversation

@mkalish
Copy link
Member

@mkalish mkalish commented Oct 15, 2018

No description provided.

@mkalish
Copy link
Member Author

mkalish commented Oct 15, 2018

@rbmy FYI

@rbmy
Copy link
Contributor

rbmy commented Oct 15, 2018

will this be merged or replace what's in the master branch? I believe this is the feature/docker-v2 branch only.

rbmy
rbmy reviewed Oct 16, 2018
View reviewed changes
Copy link
Contributor

@rbmy rbmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Dockerfile:
I see that you commented out the lines for make migrations and migrate. The purpose of these is to update the database upon start up if the model (think schema) is updated. I've verified that if it runs and there are no changes then no action is performed.

For ancfinder/urls.py:
path('well-known/', include('lets encrypt.urls')) can be removed. This was an attempt at using Django's admin console for generating a challenge.

@mkalish
Copy link
Member Author

mkalish commented Oct 16, 2018 •
edited
Loading

I'd like to get this merged into master quickly. Those database steps need to be run outside of the build process since they require the DB to be there. I'll remove the django lets encrypt

@mkalish mkalish force-pushed the feature/docker-v2 branch 6 times, most recently from b2f59da to 1c1f092 Compare October 25, 2018 00:34
@mkalish mkalish force-pushed the master branch 6 times, most recently from 9690fec to cc90728 Compare March 21, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rbmy rbmy rbmy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkalish @rbmy