Skip to content

Jade spector improvements #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jade-Spector wants to merge 7 commits into
base: gui-prototype
Choose a base branch
from
+19 −2
Open

Jade spector improvements #258

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f0c6aea
docs: Update main with new license, fix broken link (#239)
KristijanArmeni Oct 15, 2025
c646a5b
Merge branch 'gui-prototype' into jade-spector-changes
Jade-Spector Nov 7, 2025
8eba5bf
Update base.py
Jade-Spector Nov 15, 2025
ee1d55e
Merge branch 'gui-prototype' into jade-spector-changes
Jade-Spector Nov 17, 2025
4425dc4
Update base.py
Jade-Spector Nov 17, 2025
4960f88
Merge branch 'gui-prototype' of https://github.com/civictechdc/cib-ma…
Jade-Spector Jan 7, 2026
50697dd
Merge branch 'gui-prototype' into jade-spector-changes
Jade-Spector Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions gui/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,16 @@ class GuiURLS(BaseModel):
default="https://github.com/civictechdc/mango-tango-cli",
description="GitHub repository URL",
)

instagram_url: str = Field(
default="https://www.instagram.com/civictechdc/",
default="https://www.instagram.com/cibmangotree",
description="Instagram profile URL",
)

linkdlin_url: str = Field(
Copy link
Collaborator

@KristijanArmeni KristijanArmeni Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name this variable linkedin_url (instead of linkdlin_url)?

default="https://www.linkedin.com/company/cib-mango-tree",
description="Linkdlin profile ",
Copy link
Collaborator

@KristijanArmeni KristijanArmeni Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change description to "LinkedIn profile"

)

class GuiConstants(BaseModel):
"""Container for both colors and urls"""
Expand Down Expand Up @@ -304,7 +309,7 @@ def _render_footer(self) -> None:
Layout:
- Left: License information
- Center: Project attribution
- Right: External links (GitHub, Instagram)
- Right: External links (GitHub, Instagram,Linkdin)
Copy link
Collaborator

@KristijanArmeni KristijanArmeni Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"LinkedIn" (so, in string text, let's just spell out the brand as is to remove any ambiguity)

"""
with ui.footer(elevated=True):
with ui.row().classes("w-full items-center").style(
Expand Down Expand Up @@ -346,6 +351,18 @@ def _render_footer_links(self) -> None:
"width: 20px; height: 20px; fill: currentColor"
)
ui.tooltip("Follow us on Instagram")

# Linkdin button
linkdin_btn = ui.button(
color="accent",
on_click=lambda: self.navigate_to_external(gui_urls.linkdlin_url),
).props("flat round")
with linkdin_btn:
linkdin_svg = self._load_svg_icon("instagram")
Copy link
Collaborator

@KristijanArmeni KristijanArmeni Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be loading a LinkedIn logo? It's currently going to load "instagram" logo. To add an icon, you need to find an .svg of an icon, place it in gui/icons/ and modify the _load_csv_icon() method accordingly.

I found insta/github icons at https://simpleicons.org which are licensed by CC0. We should make sure that similar llicense is in place for any linked in icon too.

ui.html(linkdin_svg, sanitize=False).style(
"width: 20px; height: 20px; fill: currentColor"
)
ui.tooltip("Visit our Linkdin")

# Navigation helpers
def navigate_to(self, route: str) -> None:
Expand Down