Improvement: Audio Recorder Quality & Crash Fix #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: Audio Recorder Quality & Crash Fix
While debugging audio issues on Linux/Wayland (related to #390), I noticed the audio recorder wasn't always picking the best settings. In fact, without this change, the application was crashing in a loop on my machine due to configuration mismatches.
I updated
recorder.rsto explicitly check forF32support and prioritize that overI16orI32if available. This prevents the crash and ensures the highest possible input quality for transcription.Technical Implementation
The
get_preferred_configmethod now iterates through all supported configurations and assigns a score based on the sample format, rather than selecting the first match.Relates to #390