Add Internationalization Support #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirenMohindra
added a commit
to VirenMohindra/Handy
that referenced
this pull request
Dec 12, 2025
adds complete translations for: - german (de) - japanese (ja) - chinese simplified (zh) builds on the internationalization foundation added in cjpais#437. updates CONTRIBUTING_TRANSLATIONS.md to reflect supported languages.
4 tasks
cjpais
added a commit
that referenced
this pull request
Dec 12, 2025
* feat: add german, japanese, and chinese translations adds complete translations for: - german (de) - japanese (ja) - chinese simplified (zh) builds on the internationalization foundation added in #437. updates CONTRIBUTING_TRANSLATIONS.md to reflect supported languages. * fix: escape Chinese quotation marks in zh translation * cleanup * remove extra keys for now --------- Co-authored-by: CJ Pais <[email protected]>
Collaborator
|
@cjpais just seen this - great shout adding this. It feels a bit weird to me that this is in the About panel, since it's a setting (and the only one in this panel). I assume that you put it here because if affects only the Handy UI and not the actual functionality in use (ie transcription)? I almost feel like the panes should be something more like:
But this should probably be it's own discussion. |
Owner
Author
|
@dannysmith - yeah I initially wanted it somewhere a bit more obvious but disambiguating between what language is being transcribed vs the UI felt awkward. I really think the UI needs another overhaul generally. Maybe it makes sense to have a globe icon > English dropdown or similar somewhere. Potentially replacing the updates available bit? Or maybe it's in a consistent spot in the UI? I'm not really sure but it could use some help. I started #449 as a larger discussion about the app and UI generally |
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
* basic i18n * tweak * translate app * add linting to make sure we have translations * run linter on pr * format
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
* feat: add german, japanese, and chinese translations adds complete translations for: - german (de) - japanese (ja) - chinese simplified (zh) builds on the internationalization foundation added in cjpais#437. updates CONTRIBUTING_TRANSLATIONS.md to reflect supported languages. * fix: escape Chinese quotation marks in zh translation * cleanup * remove extra keys for now --------- Co-authored-by: CJ Pais <[email protected]>
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
* basic i18n * tweak * translate app * add linting to make sure we have translations * run linter on pr * format
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
* feat: add german, japanese, and chinese translations adds complete translations for: - german (de) - japanese (ja) - chinese simplified (zh) builds on the internationalization foundation added in cjpais#437. updates CONTRIBUTING_TRANSLATIONS.md to reflect supported languages. * fix: escape Chinese quotation marks in zh translation * cleanup * remove extra keys for now --------- Co-authored-by: CJ Pais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application language can now be changed on the "About" page