fix: prevent model auto-switch from interrupting active transcription #443
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a model download completes during an active recording/transcription, the app now skips auto-switching to prevent data loss. adds is_recording tauri command to check recording state before auto-switching models on download or extraction completion. fixes cjpais#418
Owner
|
thank you! will be testing this after i play around with something on my dev branch |
Owner
|
I tested this and seems to work. |
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
…cjpais#443) * fix: prevent model auto-switch from interrupting active transcription when a model download completes during an active recording/transcription, the app now skips auto-switching to prevent data loss. adds is_recording tauri command to check recording state before auto-switching models on download or extraction completion. fixes cjpais#418 * Update bindings.ts --------- Co-authored-by: CJ Pais <[email protected]>
zhuzhuyule
pushed a commit
to zhuzhuyule/Votype
that referenced
this pull request
Dec 13, 2025
…cjpais#443) * fix: prevent model auto-switch from interrupting active transcription when a model download completes during an active recording/transcription, the app now skips auto-switching to prevent data loss. adds is_recording tauri command to check recording state before auto-switching models on download or extraction completion. fixes cjpais#418 * Update bindings.ts --------- Co-authored-by: CJ Pais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is_recordingtauri command to check recording stateProblem
when a model finishes downloading while user is actively transcribing, the app auto-switches to the new model after 500ms, interrupting the transcription and losing data.
Solution
check recording state before auto-switching. if recording is in progress, skip the auto-switch. user can manually select the model after transcription completes.
Testing
fixes #418