fix: keybinding changes failing silently due to incorrect key ordering#524
Merged
cjpais merged 5 commits intocjpais:mainfrom Jan 10, 2026
Merged
Conversation
…tence Signed-off-by: Noorain Panjwani <noorain.panjwani@gmail.com>
Signed-off-by: Noorain Panjwani <noorain.panjwani@gmail.com>
YourTechBud
changed the title
Owner
|
Can you make sure the toast is in an appropriate style which generally matches the app style? Also pinging @joshribakoff for any opinions on the toasting and library if appropriate |
Owner
|
Thank you for these changes, I think they're quite nice and good. Merged |
h0lybyte
added a commit
to KBVE/Handy
that referenced
this pull request
Jan 12, 2026
…, and UI improvements Merged upstream features: - feat: add Czech translation (cjpais#568) - fix: keybinding changes failing silently due to incorrect key ordering (cjpais#524) - fix: improve apple intelligence ui and add reusable alert component (cjpais#517) - Fix race condition when toggling transcription via SIGUSR2 (cjpais#560) - feat(linux): add ydotool support for text input (cjpais#557) - feat: add Moonshine Base speech recognition model (cjpais#556) - Prevent highlight and selection cursor hover on UI text items (cjpais#541) - feat(ui): add reusable Tooltip component and integrate with settings (cjpais#538) - PR guidelines for AI - dont allow package-lock with a bun project for now Conflicts resolved: - src-tauri/src/shortcut.rs: Kept KBVE filler detection commands, adopted upstream's improved doc comment - src/bindings.ts: Merged KBVE types (Discord, Memory, Filler) with upstream's Moonshine engine type
aidynamicsolutions
pushed a commit
to aidynamicsolutions/codictate
that referenced
this pull request
Feb 21, 2026
Brings in latest main changes since PR cjpais#473 including: - cjpais#524: keybinding ordering fix - cjpais#517: Apple Intelligence UI improvements with Alert component - cjpais#560: SIGUSR2 race condition fix - cjpais#557: ydotool support for Linux - cjpais#556: Moonshine Base model support - cjpais#541: UI text selection prevention - cjpais#538: Tooltip component - cjpais#540: Portuguese language support - cjpais#536: Ukrainian language support Conflict resolutions: - PostProcessingSettings.tsx: Combined MLX provider support with new Alert UI - actions.rs: Fixed async block syntax issue - Lock files: Regenerated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tence
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
The problem was that my keybinding was not applying/persisting and the UI wasn't throwing errors. Turned out that we were not checking for errors. for invalid keybindings. Just fixed that.
Related Issues/Discussions
Didn't find anything related
Community Feedback
Testing
Screenshots/Videos (if applicable)