Fix audio playback in History tab on Linux#617
Merged
cjpais merged 3 commits intocjpais:mainfrom Jan 19, 2026
Merged
Conversation
Add error message translations for the permission check flow in the Portuguese locale, covering both check failures and request failures.
WebKitGTK cannot play audio files via the asset:// protocol (or at least not reliably), returning MEDIA_ERR_SRC_NOT_SUPPORTED. Additionally, convertFileSrc was double- encoding the path (/ became %2F). Changed to read audio files directly using the fs plugin and create blob URLs instead. Also added APPDATA to fs:scope permissions to allow reading recordings from the app data directory.
GabeDuarteM
changed the title
Owner
|
thank you for looking into this, but for what it's worth this breaks playback on macOS which we cannot do maybe detect os and only for linux use this new codepath in the frontend? |
The blob URL approach for audio playback works on Linux but breaks macOS. This reverts the blob change to use convertFileSrc with the asset protocol on macOS/Windows while keeping the blob approach for Linux where it's needed. Also adds proper cleanup of blob URLs to prevent memory leaks when history entries are unmounted.
Contributor
Author
|
Sure, done on the last commit! |
Owner
|
Thank you, works on my Mac now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
Btw, just wanted to mention that the link for the contributing document above is broken on the template
Human Written Description
While I was working on the flatpak pr, I noticed that the play/seek functionality on the history tab wasn't working on my machine, after investigating, I saw that it wasn't a flatpak issue, but a linux issue (or at the very least an arch-linux issue). This should fix it, and I also added some missing portuguese translations while I was at it :)
Had to add the fs:scope so we can read from the recordings folder, and also had to switch away from
convertFileSrc, since that was giving aMEDIA_ERR_SRC_NOT_SUPPORTEDerror when used, and duplicating the encoding of the url (e.g./woudl became%2F)Related Issues/Discussions
Couldn't find an issue, I just fixed it directly, but I'm happy to also file an issue/discussion if needed
Community Feedback
Testing
Tested the native dev build + the flatpak branch, both worked correctly. Couldn't get the appimage build due to the build errors on my machine (same thing that happened on the flatpak branch, which also happens to me on the main branch, not sure why tbh)
Screenshots/Videos (if applicable)
Before:
2026-01-18.21-47-37.mp4
After:
2026-01-18.21-50-00.mp4
AI Assistance
If AI was used: