Narrow typing of CKEditorCloudResult in demo, upgrade commons
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editor5-integrations-common`
Mati365
changed the title
CKEditorCloudResult in demo, upgrade `@ckeditor/ck…CKEditorCloudResult in demo, upgrade commons
Pull Request Test Coverage Report for Build 66354a1f-42d2-4212-8093-6fcaa96af855Details
💛 - Coveralls |
gorzelinski
approved these changes
Sep 12, 2024
| @@ -32,7 +35,7 @@ You learn to appreciate each and every single one of the differences while you b | |||
| .then( this._setupEditor.bind( this ) ); | |||
| } | |||
|
|
|||
| private _setupEditor( cloud: CKEditorCloudResult ) { | |||
| private _setupEditor( cloud: CKEditorCloudResult<{ version: '43.0.0' }> ) { | |||
There was a problem hiding this comment.
The version will be deprecated after some time, but it's only a demo, so it shouldn't be a problem I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Improve result type of
useCKEditorCloudto makeCKEditorPremiumFeaturesandCKBoxnon-nullable when proper configuration is passed.Fix: Rename the
languagesconfiguration property to translations inloadCKEditorCloud.