-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align integration to work with self-service for premium features. #454
Conversation
0a5fd5a
to
7036f06
Compare
Pull Request Test Coverage Report for Build 80309925-b790-4fc6-ae21-adaf81440a58Details
💛 - Coveralls |
96ff89d
to
037d1b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script for preparing the release (yarn release:prepare-packages
) modifies one file outside the release directory:
$ git status
On branch editor-integration/angular/add-usage-data
Your branch is up to date with 'origin/editor-integration/angular/add-usage-data'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: src/ckeditor/package.json
no changes added to commit (use "git add" and/or "git commit -a")
Also, in the generated release directory, there are two package.json
files:
release/ckeditor5-angular/package.json
release/ckeditor5-angular/esm2022/package.json
Is it expected?
@psmyrek 🤔 I'll check that. edit: You are right, that |
7043c63
to
970b9af
Compare
@psmyrek This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Suggested merge commit message (convention)
Feature: Align integration to work with self-service for premium features.
Additional information
More details: ckeditor/ckeditor5#17317