Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleanup of tests #543

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Improve cleanup of tests #543

merged 6 commits into from
Oct 15, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Oct 4, 2024

Suggested merge commit message (convention)

Tests: Add react testing library cleanup call before each test to reduce amount of flaky tests. Closes #542


Additional information

It looks like error handling in vitest doesn't play well with CKEditor error handling.

@Mati365 Mati365 requested a review from filipsobol October 4, 2024 12:45
@coveralls
Copy link

coveralls commented Oct 4, 2024

Pull Request Test Coverage Report for Build c3c4d789-e636-41fe-9523-bbce3022b2a8

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 876c9cb3-a6b3-4602-b29a-c127317e1f8b: 0.0%
Covered Lines: 582
Relevant Lines: 582

💛 - Coveralls

@Mati365 Mati365 requested a review from f1ames October 4, 2024 13:00
@Mati365 Mati365 merged commit 2cea7d9 into master Oct 15, 2024
5 checks passed
@Mati365 Mati365 deleted the ck/542 branch October 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky 'useMultiRootEditor' slow editor test
4 participants