Skip to content

Fix CSS selector specificity in button.css#19939

Open
filipsobol wants to merge 3 commits intomasterfrom
ci/4266-replace-postcss-with-lightningcss
Open

Fix CSS selector specificity in button.css#19939
filipsobol wants to merge 3 commits intomasterfrom
ci/4266-replace-postcss-with-lightningcss

Conversation

@filipsobol
Copy link
Member

🚀 Summary

Fix CSS selector specificity in button.css after migrating to selectors compatible with native CSS nesting (and LightningCSS).


📌 Related issues


💡 Additional information

⚠️ Blocked by ckeditor/ckeditor5-dev#1304 ⚠️


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

@filipsobol filipsobol requested a review from a team as a code owner March 10, 2026 14:25
@filipsobol filipsobol force-pushed the ci/4266-replace-postcss-with-lightningcss branch from 08c552b to 2d769d7 Compare March 10, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant