Skip to content

Update CSS reset rules to broaden the scope of .ck-reset_all-excluded class to the container wearing that class#19940

Open
oleq wants to merge 4 commits intomasterfrom
cc/9462-suggestion-styles
Open

Update CSS reset rules to broaden the scope of .ck-reset_all-excluded class to the container wearing that class#19940
oleq wants to merge 4 commits intomasterfrom
cc/9462-suggestion-styles

Conversation

@oleq
Copy link
Member

@oleq oleq commented Mar 10, 2026

🚀 Summary

Update CSS reset rules to broaden the scope of .ck-reset_all-excluded class to the container wearing that class.


📌 Related issues

See https://github.com/ckeditor/ckeditor5-commercial/issues/9410


💡 Additional information

To the QA team: After recent changes touching ck-reset_all-excluded, please run thorough checks in the areas below. This class is used where we intentionally skip the global CKEditor reset (e.g. embedded widgets, code editors, comment UI). Any change to reset behavior can affect layout and styling in these places.

Features / areas to test:

  1. Uploadcare
    • Uploadcare form – main upload dialog/form (e.g. “Upload from Uploadcare”).
    • Uploadcare image edit form – image editing dialog (crop, etc.) when using Uploadcare.
  2. Source editing (enhanced)
    • Source editing / code editor – the CodeMirror-based source view (HTML/code panel).
  3. Comments
    • Comment threads – comment thread UI (thread container and its styling).
  4. AI Chat
    • Chat feed reply items – individual reply blocks in the chat feed.
    • Chat suggestion previews – preview of the suggested content in the modal window,
    • Chat context panel – context controls / chips (e.g. “Document”, “Selection”) in the chat UI.
  5. AI Review
    • List of results – displayed in the sidebar,
    • Preview balloon – displayed after clicking a result in the list
  6. AI Translate
    • List of results – displayed in the sidebar
  7. AI Actions
    • Suggestion preview – a preview of suggested content in the dialog window

🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant