Skip to content

Refactor makefile #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chenyukang
Copy link
Contributor

I found boot/x86_64/entry64.o and boot/x86_64/main.o was checkin,
removing them got making error,
then I found boot/x86_64 is not called for making.
Do some refactors on Makefiles,

Bad effect for this patching is we need two more exporting for Mac,
It's should have no effects on Linux.

add this exporting demo to wiki should be OK:

export RUST_ROOT=/Users/yukang/code/nightly
export LINKEDITOR=/usr/local/gcc-4.8.1-for-linux64/bin/x86_64-pc-linux-ld
export ARCHIVE=/usr/local/gcc-4.8.1-for-linux64/bin/x86_64-pc-linux-ar

export CC=/usr/local/gcc-4.8.1-for-linux64/bin/x86_64-pc-linux-gcc
export OBJCPY=/usr/local/gcc-4.8.1-for-linux64/bin/x86_64-pc-linux-objcopy

@ckkashyap
Copy link
Owner

hmm ... in addition to the environment variable, it also requires someone on mac to have gcc cross compiler.
Eventually, we should replace the whole thing under boot with some implementation in assembly. We can relook at this change at that point.

@chenyukang
Copy link
Contributor Author

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants