-
Notifications
You must be signed in to change notification settings - Fork 109
Add on Demand mode #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add on Demand mode #183
Conversation
README.md
Outdated
@@ -134,7 +134,9 @@ When creating tables you can pass specific throughput settings or stream specifi | |||
|
|||
```js | |||
dynogels.createTables({ | |||
'BlogPost': {readCapacity: 5, writeCapacity: 10}, | |||
'BlogPost': { | |||
billingMode: 'PAY_PER_REQUEST' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this part of documentation is not specifically about 'on-demand' mode, maybe leave as it was before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s add one example for each option so the developer can see what is possible
PAY_PER_REQUEST is super convenient
This adds a new schema attribute, billingMode, which can be set to 'PROVISIONED' (the default) or 'PAY_PER_REQUEST', which causes the table to run in On Demand mode. This value can also be provided on a per-table basis to the dynogels.createTables` function.
9fd1395
to
ef54ad4
Compare
Rebased on current master and addressed the comment from @rchl. |
package.json
Outdated
"aws-sdk": "^2.408.0", | ||
"lodash": "^4.17.15", | ||
"aws-sdk": "^2.441.0", | ||
"lodash": "4.17.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why downgrading lodash?
Also the aws-sdk version changed but it's not reflected in package-lock.
Should run npm i
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I think this was a rebase issue. I just pushed a fix.
9717ea8
to
c5b285c
Compare
This adds a new schema attribute, billingMode, which can be set to 'PROVISIONED' (the default) or 'PAY_PER_REQUEST', which causes the table to run in On Demand mode. This value can also be provided on a per-table basis to the dynogels.createTables` function.
Fixes #182