fix: resolve all 6 CodeQL security and quality alerts#88
Merged
Conversation
- evaluator.ts: use Object.create(null) to prevent prototype pollution in buildFactData when fact_type paths contain __proto__ (alerts 5, 6) - check-anchors.ts: allow whitespace in </script > closing tags and decode & last to prevent double-unescaping (alerts 1, 4) - validate.ts: loop HTML comment stripping until stable and decode & last to prevent double-unescaping (alerts 2, 3)
254caa1 to
5abe1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 6 open CodeQL code scanning alerts.
Changes
evaluator.ts — Prototype pollution (alerts 5 & 6)
check-anchors.ts — Bad tag filter + double escaping (alerts 1 & 4)
validate.ts — Incomplete sanitization + double escaping (alerts 2 & 3)
Testing
All 142 tests pass. The one flaky test (\EPERM\ on
mSync\ in \�fterEach) is a pre-existing Dropbox file-locking issue unrelated to these changes.