This repository was archived by the owner on Jun 6, 2026. It is now read-only.
feat: add German descriptions and titles to Luxembourg source records#46
Merged
TommiLindfors merged 1 commit intoMay 29, 2026
Conversation
Contributor
|
Merged! Good call on flagging the translations as machine-assisted. We appreciate the transparency — native speaker review is definitely welcome for bereavement context. Twelve merged PRs now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Adds
title_deanddescription_deto both existing Luxembourg source records. Also addsdeto thelanguagesarray ofguichet-death-life-event.yamlwhere it was missing, and notes the German-language URLs for both pages.Changes
data/sources/lu/guichet-death-life-event.yamltitle_de: "Todesfall eines Angehörigen"description_de: German translation of the English descriptiondetolanguagesarray (Guichet page has a verified German version)noteswith German URL:https://guichet.public.lu/de/citoyens/life-event/famille-education/deces-proche.htmldata/sources/lu/guichet-death-certificate.yamltitle_de: "Sterbeurkunde"description_de: German translation of the English descriptiondealready present inlanguages✅noteswith German URL:https://guichet.public.lu/de/citoyens/justice/certificats-copies-actes-casier-judicaire/certificats-copies-actes/acte-deces.htmlTranslation note
German translations are machine-assisted. Native speaker review welcome — flagging here as good practice for a bereavement context where precise language matters.
Verified
python3 scripts/validate.py— passes (10 data files)