This repository was archived by the owner on Jun 6, 2026. It is now read-only.
feat: add Luxembourg–Germany cross-border corridor — #40 PR 3/4#49
Merged
Merged
Conversation
TommiLindfors
approved these changes
May 31, 2026
Contributor
TommiLindfors
left a comment
TommiLindfors
left a comment
There was a problem hiding this comment.
Hi Hiren! 🎉
Another fantastic contribution - thank you for keeping up this incredible momentum on the cross-border corridors!
The Germany corridor is structured beautifully and follows the same clean pattern as the France PR. A few things I particularly appreciate:
- Sterbevierteljahr detail in both the scenario notes and the Hinterbliebenenrente source - this 3-month transitional provision is exactly the kind of critical, non-obvious fact that families need to know about
- DRV regional carrier context (Rheinland-Pfalz and Saarland as competent carriers for Luxembourg frontaliers) - very helpful for guiding people to the right office
- Bilingual descriptions (EN + DE) on both source records, consistent with the pattern we established
- institution_ids cross-references correctly linking sources back to the DRV institution record
Schema validation passes. Merging now with squash.
One PR left in the #40 series (Belgium + Portugal) - looking forward to it! 🚀
TommiLindfors
pushed a commit
that referenced
this pull request
May 31, 2026
Part 4 of 4 for issue #40. Completes the cross-border corridor infrastructure with Belgium and Portugal. --- ## Context This PR adds the two remaining corridors: - **Belgium** — ~50,000 daily frontaliers, third largest corridor - **Portugal** — ~100,000 residents, the largest foreign national community in Luxembourg --- ## Files added ### `data/sources/be/belgium-be-deces.yaml` **URL verified:** https://www.belgium.be/fr/famille/deces — loads correctly, title confirmed as "Décès". - `source_type: government_portal` - `verification_status: source-checked` - `languages: [fr, nl, de]` — belgium.be is trilingual - Includes `title_fr`, `title_de`, `description_fr`, `description_de` **Key facts documented in notes (from issue #40 research):** - Death must be declared to the municipality where the person died, usually handled by the undertaker - Death certificate is then forwarded to the municipality of last residence - Succession duties in Belgium are regional and depend on fiscal residence --- ### `data/institutions/be/sfp.yaml` **URL verified:** https://www.sfpd.fgov.be — loads correctly as "Federal Pensions Service". - `id: institution:be:sfp` - `verification_status: structured-from-source` - `languages: [fr, nl, de]` — Belgian trilingual institution (SFP in French, FPD in Dutch) - References `source:be:belgium-be-deces` **Key facts documented in notes:** - Survivor pension applications submitted via mypension.be - Coordinates with CNAP via EU social security coordination for cross-border cases - Covers ~50,000 Belgian frontaliers --- ### `data/scenarios/corridor-lu-be.yaml` - `scenario_type: corridor` - `countries: [LU, BE]` - `publication_status: draft` - References all 5 PR1 conditions and both EU sources + BE source --- ### `data/sources/pt/gov-pt-obito.yaml` **URL:** https://eportugal.gov.pt/en/temas/familia/morte — identified from official ePortugal portal structure; page was inaccessible during creation. - `source_type: government_portal` - `verification_status: discovered` — honest status, URL could not be confirmed loading - `last_verified_at: null` - Notes explicitly state full content verification requires further access **Key facts encoded from issue #40 research:** - Death of a Portuguese citizen abroad must be declared in Portugal - Survivor pension (pensão de sobrevivência) requires minimum 36 months of contributions - Application via Segurança Social Direta using form RP 5075 --- ### `data/institutions/pt/seguranca-social.yaml` **URL:** https://www.seg-social.pt — confirmed loading from research. - `id: institution:pt:seguranca-social` - `verification_status: discovered` — consistent with PT source status - `languages: [pt]` **Key facts documented in notes:** - Portugal has the largest foreign national community in Luxembourg (~100,000 residents) - 36-month contribution requirement for survivor pension - Death of Portuguese national abroad must be registered in Portugal via consular services - Centro Nacional de Pensões (CNP) within ISS handles international pension coordination --- ### `data/scenarios/corridor-lu-pt.yaml` - `scenario_type: corridor` - `countries: [LU, PT]` - `publication_status: draft` - Notes explicitly flag that further source verification is needed for full PT corridor detail --- ## Verification status honesty Belgium sources are `source-checked` — URLs verified loading, content confirmed. Portugal sources are `discovered` — URL identified from official portal structure but could not be verified loading during creation. This is consistent with issue #40's own note: "Detailed survivor-pension routing and death transcription process need further verification." --- ## Issue #40 complete With this PR all four corridors are now in main: - PR 1/4 (#47) — EU foundation (conditions + EU regulations) ✅ - PR 2/4 (#48) — France corridor ✅ - PR 3/4 (#49) — Germany corridor ✅ - PR 4/4 (this PR) — Belgium + Portugal corridors Total new files across all 4 PRs: 25 files covering 2 EU regulations, 5 cross-border conditions, 4 corridor scenarios, 6 foreign sources, 5 foreign institutions. --- ## Schema compliance - All schemas read before writing — `additionalProperties: false` respected throughout - All condition IDs reference conditions from PR 1 (merged) - All EU source IDs reference sources from PR 1 (merged) - `institution_ids` and `source_ids` cross-references consistent within each PR --- ## Verified - `python3 scripts/validate.py` — passes (34 data files, up from 28) - All 6 trailing newlines confirmed `0a` - 6 new files, 0 existing files modified - `git status` confirmed no unintended changes
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 4 for issue #40. Adds the Germany corridor: 2 German sources, 1 German institution, and the LU–DE corridor scenario.
Context
Germany is the second largest frontalier corridor for Luxembourg — approximately 55,000 workers cross the border daily, primarily from Rhineland-Palatinate and Saarland. This PR encodes the DRV sources and institution a Luxembourg-connected family with German ties would interact with, and wires them into a corridor scenario referencing the cross-border conditions and EU regulations from PR 1.
Files added
data/sources/de/drv-hinterbliebenenrente.yamlURL verified: https://www.deutsche-rentenversicherung.de/DRV/DE/Rente/In-der-Rente/Hinterbliebenenrente/hinterbliebenenrente_node.html — loads correctly, title confirmed as "Renten für Hinterbliebene".
source_type: institutional_pageverification_status: source-checkedinstitution_ids: [institution:de:drv]— references DRV institution created in this same PRKey facts documented in notes (from issue #40 research):
data/sources/de/drv-rente-und-ausland.yamlURL verified: https://www.deutsche-rentenversicherung.de/DRV/DE/Rente/Ausland/ausland_node.html — loads correctly, title confirmed as "Arbeit und Rente im Ausland".
source_type: institutional_pageverification_status: source-checkedinstitution_ids: [institution:de:drv]Key facts documented in notes:
data/institutions/de/drv.yamlURL verified: https://www.deutsche-rentenversicherung.de — loads correctly.
id: institution:de:drvverification_status: structured-from-sourceKey facts documented in notes:
data/scenarios/corridor-lu-de.yamlscenario_type: corridorcountries: [LU, DE]publication_status: draftdeceased-is-foreign-national,deceased-is-frontalier,survivor-resides-abroad,assets-in-multiple-jurisdictions,repatriation-of-remainsKey corridor facts documented in notes:
Schema compliance
additionalProperties: falserespected throughoutinstitution_idson DE source records referenceinstitution:de:drvcreated in this same PR — dependency within PR is valid since validator checks schema compliance, not referential integrityofficial_siteconfirmed loadingcondition_idsreference conditions merged in PR 1 — dependency respectedWhat PR 4 will add
scenario:corridor-lu-be+ 1 BE source + 1 BE institutionscenario:corridor-lu-pt+ 1 PT source + 1 PT institutionVerified
python3 scripts/validate.py— passes (28 data files, up from 24)0agit statusconfirmed no unintended changes