Skip to content

Fully normalize type families in normalizeType. #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

alex-mckenna
Copy link
Contributor

Normalize type did not recurse on the result of reducing a type
family, meaning if a type family reduced to another type family it
would not be normalized.

Closes #1469

Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a TODO saying we need to investigate whether we can do this in reduceTypeFamily for performance improvements? We need to traverse (possibly big) types potentially many times now.

Normalize type did not recurse on the result of reducing a type
family, meaning if a type family reduced to another type family it
would not be normalized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalizeType could be implemented more efficiently
2 participants