feat: migration webhook for v1alpha1 to v1alpha2 - #339
Draft
gauravgahlot wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Gaurav Gahlot <gaurav.gahlot@ionos.com>
Signed-off-by: Gaurav Gahlot <gaurav.gahlot@ionos.com>
Signed-off-by: Gaurav Gahlot <gaurav.gahlot@ionos.com>
Signed-off-by: Gaurav Gahlot <gaurav.gahlot@ionos.com>
| } | ||
|
|
||
| if src.Gateway != nil { | ||
| v := v1alpha2.GatewayComponent(*src.Gateway) |
There was a problem hiding this comment.
This is not possible anymore due to the introduction of SectionName and Port in the GatewayComponent struct
| errKCPTmplHubTypeMismatch = errors.New("cannot convert KamajiControlPlaneTemplate: hub is not *v1alpha2.KamajiControlPlaneTemplate") | ||
| ) | ||
|
|
||
| func (src *KamajiControlPlane) ConvertTo(dstRaw conversion.Hub) error { |
There was a problem hiding this comment.
We are missing FailureReason and FailureMessage
Comment on lines
+86
to
+88
| // availableReplicas — new in v1alpha2, dropped on round trip | ||
| // (controller repopulates on next reconcile) | ||
| src.Status.Conditions = hub.Status.Conditions |
There was a problem hiding this comment.
I believe this is the case for more fields here, but if we want, we can calculate this before the reconciliation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.