fix: reduce database privileges for kine user#860
Merged
prometherion merged 2 commits intoclastix:masterfrom Dec 5, 2025
Merged
fix: reduce database privileges for kine user#860prometherion merged 2 commits intoclastix:masterfrom
prometherion merged 2 commits intoclastix:masterfrom
Conversation
✅ Deploy Preview for kamaji-documentation canceled.
|
mateuszkwiatkowski
changed the title
Member
|
@mateuszkwiatkowski we had some issues with CI, may I ask you to rebase, please? |
mateuszkwiatkowski
force-pushed
the
reduce-mysql-permissions
branch
from
94ed7e1 to
be397a8
Compare
Contributor
Author
|
@prometherion I cleaned this PR - previously it was based on my local fork and i had to rebase. It should be good to go now. |
prometherion
reviewed
Dec 5, 2025
Member
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
I'm a bit worried CI is not getting green, especially regarding migration: it seems unrelated to changes we want to introduce with this PR, trying to understand if this is just flakiness.
| postgresqlShowTableOwnershipStatement = "SELECT 't' from pg_tables where tableowner = ? AND tablename = ?" | ||
| postgresqlKineTableExistsStatement = "SELECT 't' FROM pg_tables WHERE schemaname = ? AND tablename = ?" | ||
| postgresqlGrantPrivilegesStatement = "GRANT ALL PRIVILEGES ON DATABASE %s TO %s" | ||
| postgresqlGrantPrivilegesStatement = "GRANT CONNECT, CREATE ON DATABASE %s TO %s" |
Member
There was a problem hiding this comment.
I had some remarks here, given the fact that we need to perform deletions for Datastore compaction, but I tried on my own, and it worked as expected.
prometherion
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits SQL databases permisssions.
Fixes #820