Skip to content

Conversation

@mandli
Copy link
Member

@mandli mandli commented Sep 8, 2025

@rjleveque
Copy link
Member

It used to be that file_format = "binary" meant binary64, but now it means binary32 with the new

    format_map = {'ascii':1, 'binary':2, 'binary32':2, 'binary64':3}

It seems like the default should be full precision? That would be consistent with the convention used for fort files in /Users/rjl/git/clawpack/pyclaw/src/pyclaw/fileio/binary.py and also the convention used for fgout grids.
So I suggest changing this to

    format_map = {'ascii':1, 'binary':3, 'binary32':2, 'binary64':3}

@mandli
Copy link
Member Author

mandli commented Sep 10, 2025

Yeah, that sounds right to me, thanks for catching that.

@rjleveque
Copy link
Member

Thanks @mandli, I'll work on the release later today.

@rjleveque rjleveque merged commit 686c733 into clawpack:master Sep 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants