Skip to content

Fix Bug in qinit in advection_2d_inflow Example #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Fix Bug in qinit in advection_2d_inflow Example #311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef7b9e4
Fix bug in qinit from xi and yj not being declared real(kind=8)
mandli Oct 31, 2025
7314cef
Add explicitly types variables and function
mandli Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions examples/advection_2d_inflow/qinit.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,23 @@ subroutine qinit(meqn,mbc,mx,my,xlower,ylower,dx,dy,q,maux,aux)
! q = 1.0 if 0.1 < x < 0.6 and 0.1 < y < 0.6
! 0.1 otherwise

implicit none

integer, intent(in) :: meqn, mbc, mx, my, maux
real(kind=8), intent(in) :: xlower, ylower, dx, dy
real(kind=8), intent(in out) :: q(meqn, 1-mbc:mx+mbc, 1-mbc:my+mbc)
real(kind=8), intent(in out) :: aux(maux, 1-mbc:mx+mbc, 1-mbc:my+mbc)

real(kind=8), external :: qtrue
integer :: i, j
real(kind=8) :: xi, yj

! True solution for BCs
interface
real(kind=8) pure function qtrue(x, y ,t)
implicit none
real(kind=8), intent(in) :: x, y ,t
end function qtrue
end interface

! set concentration profile
do j=1,my
Expand All @@ -21,4 +32,4 @@ subroutine qinit(meqn,mbc,mx,my,xlower,ylower,dx,dy,q,maux,aux)
end do
end do

end subroutine qinit
end subroutine qinit
Loading