Skip to content

Conversation

@mandli
Copy link
Member

@mandli mandli commented Sep 5, 2025

Addresses #667

@mandli mandli marked this pull request as draft September 5, 2025 02:52
@mandli
Copy link
Member Author

mandli commented Sep 5, 2025

This also adds actualstep checks for storm fields and multilayer stuff.

@mandli
Copy link
Member Author

mandli commented Sep 5, 2025

Also adds an initialization for tend_force_dry as it is used without being defined in qinit_module otherwise. Sets the default value to tend_force_dry = -huge(1.d0).

@rjleveque
Copy link
Member

Lots of white space is cleaned up too, which is good to do but makes it a bit hard to see all the actual code changes.

One thing I noticed is that the call to stepgrid in advanc.f and prepbigstep no longer has actualstep in the parameter list, but it is still in calling sequence in stepgrid.f. It's not used in stepgrid now, so remove it, and also from multilayer/stepgrid.f and bouss/stepgrid.f ?

@mandli
Copy link
Member Author

mandli commented Sep 5, 2025

I just added those changes (I think I got them all).

Sorry about the whitespace, switched editors and the new one has a setting that strips it and I keep forgetting to catch that.

@rjleveque
Copy link
Member

Seems to work, but this time I will run all the examples again before releasing!

@rjleveque rjleveque marked this pull request as ready for review September 7, 2025 18:09
@rjleveque rjleveque merged commit 921c376 into clawpack:master Sep 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants