change dtopotools._load_sift_unit_sources to use pooch #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo_sz.dat also updated the version in the data/ directory (no change in unit source data itself) and this will still be used if pooch fails. `known_hash` can be used in future to see if file has changed online. This change motivated by the fact that `pip install clawpack` does not expose the local version in data/ and so using `dtopotools.SiftFault` fails in Github Actions when building a Juptyer Book there.
Member
|
This looks fine to me, but I had to ask if "pooch" is an acronym or just an entertaining name for a data repository. Is "dog house" involved? |
Member
Author
I think the idea is that it fetches things for you. Seems like a useful package, https://www.fatiando.org/pooch/latest/about.html |
Member
Author
|
And for the particular case of the file from http://sift.pmel.noaa.gov/ComMIT/compressed/info_sz.dat, I like the fact that it tests a checksum and can alert us if NOAA changes their unit source definitions at some point in the future, so we don't have a stale version hardwired into GeoClaw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to download directly from
http://sift.pmel.noaa.gov/ComMIT/compressed/info_sz.datif it's not in the pooch cache.Also updated the version in the data/ directory (no change in unit source data itself) and this will still be used if pooch fails.
known_hashcan be used in future to see if file has changed online.This change was motivated by the fact that
pip install clawpackdoes not expose the local version in data/ and so usingdtopotools.SiftFaultfails in Github Actions when building a Juptyer Book there.