Updated problem_16.md #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increaseCap() might create a new vector base if it needs to grow, and so we should calculate the offset first. That way, we have avoid having possibly undefined behavior from "subtracting" two pointers who point to different memory blocks. In the event that increaseCap() would resize, posn would still point to the old array (and be invalidated) whereas begin() would point the the new array, being two separate memory blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increaseCap() might create a new vector base if it needs to grow, and so we should calculate the offset first. That way, we have avoid having possibly undefined behavior from "subtracting" two pointers who point to different memory blocks. In the event that increaseCap() would resize, posn would still point to the old array (and be invalidated) whereas begin() would point the the new array, being two separate memory blocks.