Disable morning/evening brightness adjust#100
Open
sagaalicekarlsson wants to merge 2 commits intoclaytonjn:mainfrom
Open
Disable morning/evening brightness adjust#100sagaalicekarlsson wants to merge 2 commits intoclaytonjn:mainfrom
sagaalicekarlsson wants to merge 2 commits intoclaytonjn:mainfrom
Conversation
Direction is 1 for brightness increase, -1 for brightness decrease and 0 for unchanged brightness
Ignores brightness changes in the morning when CONF_DISABLE_BRIGHTNESS_ADJUST_MORNING is set to true and in the evening if CONF_DISABLE_BRIGHTNESS_ADJUST_EVENING is set to true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This is a pull request that is inspired by the existing CONF_DISABLE_BRIGHTNESS_ADJUST configuration, but split into morning & evening. The use case is that I am using a wake up light that configures brightness separately from the circadian lightning, but I do not want to miss out on the evening functionality by setting CONF_DISABLE_BRIGHTNESS_ADJUST to true. Instead, this PR allows for disabling the brightness adjust in the morning (or evening) while maintaining the brightness adjust for the other part of the day, as well as maintaining the color temperature from circadian while using a separate wake up light.
Feel free to ask if anything is unclear, and thank you for a well working and highly appreciated integration!