Added support for min and max value templates#66
Open
stigvi wants to merge 3 commits intoclaytonjn:mainfrom
Open
Added support for min and max value templates#66stigvi wants to merge 3 commits intoclaytonjn:mainfrom
stigvi wants to merge 3 commits intoclaytonjn:mainfrom
Conversation
Owner
|
My initial impressions look good. Not sure when I'll be able to look at it in more detail (was in the hospital yesterday). One thing I'm curious about it if there's any reason to have separate _template config options or if it would be better to just have min_brightness and max_brightness take templates directly. |
added 2 commits
April 28, 2020 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.