Remove Hortusfox deployment#2313
Conversation
Drop the Hortusfox Kubernetes manifests so Argo CD no longer generates the application from the repo. Remove the generated Authentik proxy provider and detach it from the embedded outpost provider list.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (15)
WalkthroughThis PR decommissions the HortusFox application by removing all associated infrastructure: Kubernetes manifests (namespace, deployments, services, ingress, secrets, persistent volumes), MariaDB database components, password generators, and Authentik SSO configuration. The sole active code change removes the hortusfox proxy provider reference from the Authentik embedded outpost configuration. ChangesHortusFox Application Removal
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly Related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes the Hortusfox application from GitOps by deleting its Kubernetes manifests and removing the corresponding Authentik proxy provider/application from the embedded outpost configuration, so Argo CD/ApplicationSet no longer generates or manages Hortusfox.
Changes:
- Removed
authentik_provider_proxy.hortusfoxfrom the embedded outpostprotocol_providerslist. - Deleted the auto-generated Authentik Hortusfox proxy provider + application Terraform resources.
- Deleted the Hortusfox Kubernetes kustomization and all associated manifests (namespace, app, DB, secrets, ingress, cronjob, PVCs, services).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| opentofu/modules/authentik/generated-outpost.tf | Drops Hortusfox from the embedded outpost provider attachment list. |
| opentofu/modules/authentik/generated-hortusfox.tf | Removes the Authentik proxy provider + application resources for Hortusfox. |
| kubernetes/hortusfox/kustomization.yaml | Removes Hortusfox from Kustomize/Argo-managed resources. |
| kubernetes/hortusfox/namespace.yaml | Removes the Hortusfox namespace definition from GitOps source. |
| kubernetes/hortusfox/deployment.yaml | Removes the Hortusfox app deployment manifest. |
| kubernetes/hortusfox/service.yaml | Removes the Hortusfox service manifest. |
| kubernetes/hortusfox/ingress.yaml | Removes the Hortusfox ingress (and related homepage/traefik/authentik annotations). |
| kubernetes/hortusfox/pvc.yaml | Removes the app PVC manifest. |
| kubernetes/hortusfox/mariadb-deployment.yaml | Removes the MariaDB deployment backing Hortusfox. |
| kubernetes/hortusfox/mariadb-service.yaml | Removes the MariaDB service manifest. |
| kubernetes/hortusfox/mariadb-pvc.yaml | Removes the MariaDB PVC manifest. |
| kubernetes/hortusfox/password-generators.yaml | Removes External Secrets password generator resources for Hortusfox. |
| kubernetes/hortusfox/mariadb-secret.yaml | Removes the ExternalSecret for MariaDB credentials. |
| kubernetes/hortusfox/app-secret.yaml | Removes the ExternalSecrets for app admin/cron password and SMTP relay secret. |
| kubernetes/hortusfox/cronjob.yaml | Removes the CronJob that triggers Hortusfox scheduled endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3025c76162
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,22 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
Deleting this kustomization.yaml removes Hortusfox from the ApplicationSet git generator (kubernetes/argocd/appset.yaml matches kubernetes/*/kustomization.yaml), but that same ApplicationSet has spec.syncPolicy.preserveResourcesOnDeletion: true, so when the generated hortusfox Application disappears Argo CD preserves the resources instead of pruning them. In this cluster context the Deployment/Services/PVCs/Ingress remain orphaned and Hortusfox keeps running rather than being removed; retire the resources while the Application still exists or temporarily disable preservation for this app.
Useful? React with 👍 / 👎.
Drop the Hortusfox Kubernetes manifests so the ApplicationSet no longer generates a Hortusfox Argo CD application.
Remove the generated Authentik proxy provider and detach it from the embedded outpost provider list.
Note: the ApplicationSet has preserveResourcesOnDeletion enabled, so this removes Hortusfox from GitOps source but does not by itself delete any live Hortusfox Kubernetes resources that already exist.