Add feature to automatically close ERR_CACHE_MISS page#2
Merged
Conversation
…onCanceler Now it is used not only as a talk client but also to directly close tabs.
HashidaTKS
commented
Aug 13, 2025
| if (this.match(section, urlToMatch)) { | ||
| console.log(` => unmatched`); | ||
| this.startMonitoring(); | ||
| callbackWhenMatch(); |
Contributor
Author
There was a problem hiding this comment.
今回の機能追加で、このメソッドを流用したい。ただ、今回追加した部分と従来の部分でマッチした場合にさせたい動作が異なる。
- ERR_CACHE_MISSページのURLが合致していた場合はタブを閉じたい。
- それ以外の場合は、RepostConfirmationCanceler.exeを起動したい。
マッチ時にさせたい動作が異なるので、コールバック化して外部から渡せるようにした。
HashidaTKS
commented
Aug 13, 2025
| * } | ||
| */ | ||
| const RepostConfirmationCancelerTalkClient = { | ||
| const RepostConfirmationCanceler = { |
Contributor
Author
There was a problem hiding this comment.
このオブジェクトの中にERR_CACHE_MISSのページだったらタブを閉じる、という処理を追加した。
そのため単なるTalkClientではなくなったのでリネームした。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feature to automatically close ERR_CACHE_MISS page like below.