-
Notifications
You must be signed in to change notification settings - Fork 0
321 vat number median height #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Why did you remove the old spec? |
The old spec depends on median height which we don't need anymore due to the new Tesseract version. Now tesseract recognizes IE6388047V as a whole word on a google bill. |
The old tesseract recognized IE then Rechnung and then 6388047V which isn't valid! Therefore we used the median height to remove the Rechnung. But now it recognizes IE6388047V as a whole word! |
If I understand correctly then, you didn't really remove the spec but update it with data from the newest version of tesseract? |
right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising! 👍
If I understand correctly, we do, in fact, not need the median height hack since the new version of tesseract picks up the vat ID as a single word. Why did you test it with a different file though? Can you just rewrite the data with the old file? this way we can know for sure this works for all files that required this weird quirky hack.
Oh wow, that's so annoying! Have you checked with other google bills to see if this is a common occurrence? Let me know if you need more bill IDs! |
If you take a look at the list you will see that on the checked ones it gets recognized(I've tested every bill id) |
Closes #321
Works fine 👍