Compatibility with TagLib 2.0 #7314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the checks above give you your answer there :-) |
|
Thank you, may build fine with this patch |
|
Hi, |
DarthGandalf
pushed a commit
to DarthGandalf/Clementine
that referenced
this pull request
Jan 9, 2025
Patch from clementine-player#7314 Fixes clementine-player#7313 Close clementine-player#7314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagLib recently updated to version 2.0 and introduced breaking changes due to function deprecations and type changes. This patch updates Clementine to be compatible with TagLib 2.0.
I can confirm that this builds and works on my Arch Linux machine with TagLib 2.0, but I haven't tested it with TagLib 1.x. More testing may be warranted if support for TagLib 1.x is desired.
Fixes #7313.