feat: make parquet row groups size configurable #158
Merged
alamb merged 23 commits intoAug 18, 2025
Conversation
alamb
reviewed
Jul 16, 2025
alamb
left a comment
alamb
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @kevinjqliu -- I left some suggestions for your review
Collaborator
|
I am going to take the liberty and polish up this PR and get it ready to merge |
alamb
reviewed
Aug 16, 2025
Collaborator
|
@kevinjqliu and @clflushopt -- I wonder if I can trouble either if you for a review of this PR? It is mostly tests |
clflushopt
approved these changes
Aug 17, 2025
clflushopt
left a comment
clflushopt
left a comment
Owner
There was a problem hiding this comment.
An awesome PR thanks @alamb for pushing this through ! I left some minor nitpicks that are non-blocking (just generic comment improvements). LGTM !
Co-authored-by: @clflushopt <172141496+clflushopt@users.noreply.github.com>
Collaborator
|
Thank you for the review @clflushopt ! |
Collaborator
Author
|
Thank you both for getting this across the finish line! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.