chore: Add tbl/csv subcommands, deprecate --format flag#255
Merged
Conversation
clflushopt
approved these changes
May 10, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
09166c0 to
d9f54c1
Compare
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Collaborator
Author
|
i thoroughly tested all the commands listed in this repo and all the error cases. all commands ran successfully locally |
Co-authored-by: Copilot <copilot@github.com>
clflushopt
reviewed
May 10, 2026
Owner
clflushopt
left a comment
There was a problem hiding this comment.
Left a couple on questions on how some args are unwraped prior to being checked via is_some() I think we should align that logic.
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
kevinjqliu
commented
May 11, 2026
Collaborator
Author
|
@clflushopt im pretty happy with these changes, lmk if you have any other feedback! |
Collaborator
Author
|
moving this forward, will fix forward if anything comes up 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #254.
Closes #173.
Adds
tblandcsvsubcommands alongside the existingparquetsubcommand so every output format is a first-class subcommand. The top-level--format,--parquet-compression, and--parquet-row-group-bytesflags are deprecated (removal in v4.0.0).Note that the default behavior remains unchanged. Running without
--formatand without a subcommand (e.g.tpchgen-cli -s 10) still defaults to TBL output, preserving backward compatibility.Changes
New subcommands
tpchgen-cli tbl— generates TBL (pipe-delimited) outputtpchgen-cli csv— generates CSV output, with--delimiteroptiontpchgen-cli parquet— (already added in chore: Follow-up improvements to parquet subcommand CLI #254)Deprecated flags (hidden from
--help, warn on use, removed in v4.0.0)--format— usetbl,csv, orparquetsubcommand instead--parquet-compression— useparquet --compression=...--parquet-row-group-bytes— useparquet --row-group-bytes=...--delimiterat top level — removed, move to csv subcommand; usetpchgen-cli csv --delimiter=...instead (we never released with--delimiter, so not a breaking change)Bug fix
Mixing top-level args with a subcommand (e.g.
tpchgen-cli -s 10 parquet) now errors instead of silently ignoring the top-level args (args_conflicts_with_subcommands)csv --delimiterrejects non-ASCII characters at parse time (e.g.--delimiter='€') instead of failing mid-generation, since the underlying arrow-csv writer requires an ASCII byte