-
Notifications
You must be signed in to change notification settings - Fork 59
Support asyncclick and click #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is very challenging to review at the moment. You need to keep the formatting changes to a separate commit or (better) a separate PR before I'm able to review this. Ditto for other unrelated changes like changing the Python version supported. We can drop python 3.8 now but I'd rather keep 3.9 around until EOL. They should be all separate commits or PRs so we can discuss their merits individually. |
Sorry for that. :-( I will fix the black autofixer thingies next week.
I will create a own commit for it. But it's no problem for me if you wait ~6 month till you merge it. The python 3.10 syntax replacing Union is way more comfortable and you can use it in isinstance, too. The fork works for my purposes right now. |
Thanks 🙏
You can achieve this by with the |
cc9ce93
to
ec3a745
Compare
1. only click is installed 2. only asyncclick is installed 3. asyncclick and click are installed Signed-off-by: Jürgen Löhel <[email protected]>
Signed-off-by: Jürgen Löhel <[email protected]>
@stephenfin I have cleaned a bit. |
Summary
Support asyncclick and click at the same time. It should fix #144