Skip to content

Support asyncclick and click #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jloehel
Copy link

@jloehel jloehel commented Apr 10, 2025

Summary

Support asyncclick and click at the same time. It should fix #144

@jloehel jloehel marked this pull request as draft April 10, 2025 05:30
@stephenfin
Copy link
Member

stephenfin commented Apr 11, 2025

This is very challenging to review at the moment. You need to keep the formatting changes to a separate commit or (better) a separate PR before I'm able to review this.

Ditto for other unrelated changes like changing the Python version supported. We can drop python 3.8 now but I'd rather keep 3.9 around until EOL. They should be all separate commits or PRs so we can discuss their merits individually.

@jloehel
Copy link
Author

jloehel commented Apr 12, 2025

This is very challenging to review at the moment. You need to keep the formatting changes to a separate commit or (better) a separate PR before I'm able to review this.

Sorry for that. :-( I will fix the black autofixer thingies next week.

Ditto for other unrelated changes like changing the Python version supported. We can drop python 3.8 now but I'd rather keep 3.9 around until EOL. They should be all separate commits or PRs so we can discuss their merits individually.

I will create a own commit for it. But it's no problem for me if you wait ~6 month till you merge it. The python 3.10 syntax replacing Union is way more comfortable and you can use it in isinstance, too. The fork works for my purposes right now.

@stephenfin
Copy link
Member

This is very challenging to review at the moment. You need to keep the formatting changes to a separate commit or (better) a separate PR before I'm able to review this.

Sorry for that. :-( I will fix the black autofixer thingies next week.

Thanks 🙏

Ditto for other unrelated changes like changing the Python version supported. We can drop python 3.8 now but I'd rather keep 3.9 around until EOL. They should be all separate commits or PRs so we can discuss their merits individually.

I will create a own commit for it. But it's no problem for me if you wait ~6 month till you merge it. The python 3.10 syntax replacing Union is way more comfortable and you can use it in isinstance, too. The fork works for my purposes right now.

You can achieve this by with the annotations future import also. No need to drop support for anything.

@jloehel jloehel force-pushed the wip-asyncclick branch 5 times, most recently from cc9ce93 to ec3a745 Compare April 14, 2025 19:04
1. only click is installed
2. only asyncclick is installed
3. asyncclick and click are installed

Signed-off-by: Jürgen Löhel <[email protected]>
Signed-off-by: Jürgen Löhel <[email protected]>
@jloehel
Copy link
Author

jloehel commented Apr 14, 2025

@stephenfin I have cleaned a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate documentation using asyncclick
2 participants