Open
Conversation
Add Laravel facades for easier access to parser and generator classes, eliminating the need for app()->make() boilerplate. New facades: - WKBParser, WKTParser, GeojsonParser (for parsing) - WKBGenerator, WKTGenerator, GeojsonGenerator (for generating) Closes #110 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
46dd02a to
a35b03c
Compare
📝 WalkthroughWalkthroughThis PR introduces six new Laravel facades (WKBParser, WKTParser, GeojsonParser, WKBGenerator, WKTGenerator, GeojsonGenerator) to replace the single generic Magellan facade, enabling simpler static API calls. The old facade alias is removed from configuration, and the new facades are registered in the service provider. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app()->make()New Facades:
WKBParserWKBParserWKTParserWKTParserGeojsonParserGeojsonParserWKBGeneratorWKBGeneratorWKTGeneratorWKTGeneratorGeojsonGeneratorGeojsonGeneratorBefore:
After:
Closes #110
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes