Get tests back to a passing state #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonKlotz
commented
Mar 21, 2025
| FactoryBot.create(:count, tracker: tracker, action: "created", name: "Blah", count: 3) | ||
|
|
||
| Billing::Usage::ProductCatalog.stub(:all_products, all_products) do | ||
| assert_equal limiter.exhausted_usage_for(limit, :create, "Blah"), 3 | ||
| assert_equal 3, limiter.exhausted_usage_for(limit, :create, "Blah") |
There was a problem hiding this comment.
Updated so the test correctly returns what was expected vs. actual
BrandonKlotz
commented
Mar 21, 2025
Comment on lines
+10
to
+41
| # Determine if workspace_id is a valid column | ||
| has_workspace_column = Billing::Usage::Tracker.column_names.include?('workspace_id') | ||
| has_team_column = Billing::Usage::Tracker.column_names.include?('team_id') | ||
|
|
||
| # Get the attributes common to all environments | ||
| tracker_attributes = { | ||
| duration: duration, | ||
| interval: interval | ||
| ) | ||
| } | ||
|
|
||
| # Only add workspace_id if it exists in the schema | ||
| if has_workspace_column | ||
| workspace_id = if defined?(::Workspace) && proxy_association.owner.is_a?(::Workspace) | ||
| proxy_association.owner.id | ||
| elsif proxy_association.owner.respond_to?(:workspace) && proxy_association.owner.workspace.present? | ||
| proxy_association.owner.workspace.id | ||
| elsif proxy_association.owner.respond_to?(:workspace_id) && proxy_association.owner.workspace_id.present? | ||
| proxy_association.owner.workspace_id | ||
| else | ||
| proxy_association.owner.id # Fallback to owner's ID | ||
| end | ||
|
|
||
| tracker_attributes[:workspace_id] = workspace_id | ||
| end | ||
|
|
||
| if has_team_column | ||
| team_id = proxy_association.owner.id | ||
| tracker_attributes[:team_id] = team_id | ||
| end | ||
|
|
||
| # Find or create the tracker with the appropriate attributes | ||
| order(created_at: :desc).includes(:counts).find_or_create_by(tracker_attributes) |
There was a problem hiding this comment.
I'm pretty hesitant about these changes, and don't know what the best move-forward plan would be. Currently, our Gem has an undesirable dependency on Workspace from our use in the admin repo which is preventing tests from running without errors in the Gem context.
BrandonKlotz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails testruns all tests without errors but there are 4 failures, that need to be looked into.Currently the forked repository passes when running tests.
https://github.com/bullet-train-pro/bullet_train-billing-usage