Fix pcf for sram for icoboard #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sram wasn't working for sram_addr >= 256*1024
splinedrive
commented
Jul 13, 2021
Author
splinedrive
left a comment
splinedrive
left a comment
There was a problem hiding this comment.
I have used the schematic from icoboard r0.3 and the datasheet of 51216 sram
|
In case anyone else encounters this. There are references to HRAM_CK which also uses N10. So this patch alone does not compile. I removed HRAM_CK from icosoc.py and that makes it compile. memtest seem to run with 1024KB SRAM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sram wasn't working for sram_addr >= 256*1024