Make sure we correctly find the association within preload_scoped_relation method #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendy-clio
requested review from
MrJakeReid,
apalmblad,
fimmtiu,
gfieldclio and
tudorbertiean
apalmblad
approved these changes
Nov 1, 2024
tudorbertiean
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing to upgrade Manage to latest jit_preloader(3.0.0, build) I found that there's some places we use string as
base_associationname when callingpreload_scoped_relationmethod(example).With the latest version, this is causing the error of not able to find the association and properly(ActiveRecord native method of finding association is only allow passing a symbol of association name reference) and therefore not caching the preload successfully.
The previous version that Manage currently use(1.0.4) also has the same bug but due to the difference ways of assigning preload values to the cache(Unfortunately, ActiveRecord has different behaviour between fetching an association and preload one), the problem is minor and not obvious.
This PR is doing a simple fix of ensuring the
base_associationis a symbol before fetching the owner object association.Take a look at this build which all tests are passing when using this PR branch jit_preloader version.