Fix failure to initialise Netty channel when using :manual-ssl? option #752
Conversation
| @@ -641,7 +641,7 @@ | |||
| :handler handler | |||
| :server? true | |||
| :pipeline pipeline)] | |||
| (cond ssl? | |||
| (cond (and ssl? ssl-context) | |||
There was a problem hiding this comment.
While the fix would work, I think it's better if it's failing (maybe more gracefully with a clearer error message) because you don't expect a server to start without TLS when the ssl? parameter is passed with true.
There was a problem hiding this comment.
Note that ssl? isn't a parameter that the user can pass to aleph.http/start-server. Instead, it is derived from manual-ssl? and ssl-context.
FTR: I haven't yet reviewed the patch but intend to do so in the course of the week. Meanwhile, thanks a lot for your contribution, @scramjet! One thing I would like is to have a regression test for this but I can also take care of that if you don't have the bandwidth 🙏
There was a problem hiding this comment.
(Off-topic: At first I accidentally linked to a Jitsi meeting room there because I failed to copy the intended URL - fixed now. Please ignore the other URL in case you got it via email notification 😅)
There was a problem hiding this comment.
Thanks for looking at this.
While the fix would work, I think it's better if it's failing (maybe more gracefully with a clearer error message) because you don't expect a server to start without TLS when the
ssl?parameter is passed withtrue
:manual-ssl? = true indicates "I'm going to add the SSL handler(s) myself, trust me I know what I'm doing", and failing like it does breaks the ability to use it at all. As @DerGuteMoritz points out, ssl? is a handy internal flag to consult to see if SSL will be used at all.
I wish I had the time to write a test right now. In fact I wish I had made one in the original PR (#423) back when I had more time. Would have saved some grief now!
Fixes #751