Skip to content

Commit

Permalink
Fix: recognized :driver-log-level for Edge (#567)
Browse files Browse the repository at this point in the history
Also add in sanity tests for WebDrivers that recognize `:driver-log-level`.

Closes #566
  • Loading branch information
lread authored Mar 22, 2024
1 parent 795bc0a commit 0000e58
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ A release with an intentional breaking changes is marked with:

* https://github.com/clj-commons/etaoin/pull/552[#552]: Add support for wide characters to input fill functions
(https://github.com/tupini07[@tupini07])
* https://github.com/clj-commons/etaoin/issues/566[#566]: Recognize `:driver-log-level` for Edge
* bump all deps to current versions
* docs
** https://github.com/clj-commons/etaoin/issues/534[#534]: better describe `etaoin.api/select` and its alternatives
Expand Down
4 changes: 2 additions & 2 deletions src/etaoin/impl/driver.clj
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,8 @@
(log/infof "The log level setting is not implemented for this driver.")
driver)

(defmethod set-driver-log-level
:chrome
(defmethods set-driver-log-level
[:chrome :edge]
[driver log-level]
(set-args driver [(format "--log-level=%s" log-level)]))

Expand Down
30 changes: 29 additions & 1 deletion test/etaoin/api_with_driver_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
[etaoin.api :as e]
[etaoin.api2 :as e2]
[etaoin.api-test :as api-test]
[etaoin.test-report]))
[etaoin.test-report]
[etaoin.impl.util :as util]))

(defn testing-driver? [type]
(some #{type} api-test/drivers))
Expand Down Expand Up @@ -241,3 +242,30 @@
(e2/with-safari [driver]
(e/go driver test-page)
(e/get-title driver))))))))

(deftest driver-log-test
(let [test-page (api-test/test-server-url "test.html")]
(when (testing-driver? :chrome)
(testing "chrome"
(println "testing chrome")
(util/with-tmp-file "chromedriver" ".log" path
;; chromedriver logs to stderr
(e/with-chrome {:driver-log-level "DEBUG" :log-stderr path} driver
(e/go driver test-page)
(is (re-find #"\[DEBUG\]:" (slurp path)))))))
(when (testing-driver? :edge)
(testing "edge"
(println "testing edge")
(util/with-tmp-file "edgedriver" ".log" path
;; edgedriver logs to stderr
(e/with-edge {:driver-log-level "DEBUG" :log-stderr path} driver
(e/go driver test-page)
(is (re-find #"\[DEBUG\]:" (slurp path)))))))
(when (testing-driver? :firefox)
(testing "firefox"
(println "testing firefox")
(util/with-tmp-file "firefoxdriver" ".log" path
;; geckodriver logs to stdout
(e/with-firefox {:driver-log-level "debug" :log-stdout path} driver
(e/go driver test-page)
(is (re-find #"\tDEBUG\t" (slurp path)))))))))

0 comments on commit 0000e58

Please sign in to comment.