Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve imported vars at runtime, not read time #73

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

NoahTheDuke
Copy link
Contributor

If a var has tag metadata attached to the var symbol (not on the vector, as is the preferred method for return types in functions), it will be resolved when import-* is called during read time. This currently doesn't break anything, but if the proposed Clojure patch for CLJ-1929 is accepted, then code that's so tagged will break.

Includes a test that will break without the associated change if the Clojure patch is accepted.

Closes #72

If a var has tag metadata attached to the var symbol (not on the vector, as is
the preferred method for return types in functions), it will be resolved when
`import-*` is called during read time. This currently doesn't break anything,
but if the proposed Clojure patch for [CLJ-1929][CLJ-1929] is accepted, then
code that's so tagged will break.

Includes a test that will break without the associated change if the Clojure
patch is accepted.

Closes [clj-commons#72][clj-commons#72]

[CLJ-1929]: https://clojure.atlassian.net/browse/CLJ-1929
[clj-commons#72]: clj-commons#72
@slipset slipset merged commit f21d5fd into clj-commons:master Mar 6, 2025
@NoahTheDuke NoahTheDuke deleted the nb/fix-CLJ-1929 branch March 6, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential breakage
2 participants