Make Timestamp and TimeDuration implement FilterableValue
#2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rafaelGuerreiro
changed the title
Timestamp and TimeDuration implement FilterableValue
|
This PR is currently marked as draft because I'll work on the C# backend, as well as the client SDK changes, if necessary. |
rafaelGuerreiro
commented
May 2, 2025
| @@ -89,6 +89,22 @@ pub enum TestF { | |||
| Baz(String), | |||
| } | |||
|
|
|||
| #[spacetimedb::table( | |||
| name = test_g, | |||
| index(name = created_at_index, btree(columns = [name, created_at])), | |||
There was a problem hiding this comment.
Add a test case for this index as well
rafaelGuerreiro
commented
May 4, 2025
| @@ -320,13 +320,16 @@ public static void insert_one_connection_id(ReducerContext ctx, ConnectionId a) | |||
| [SpacetimeDB.Table(Name = "one_timestamp", Public = true)] | |||
| public partial struct OneTimestamp | |||
| { | |||
| [SpacetimeDB.Index.BTree] | |||
There was a problem hiding this comment.
Replicate the test in module-test-cs instead of sdk-test-cs
|
This one is going to be much more work to get merged than your previous PR. It's going to need:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Making
TimestampandTimeDurationimplementFilterableValue.This resolves #2650
API and ABI breaking changes
API change is additive in this case, I'm not marking this as unstable because the
FilterableValueimplementation is already stabilized.Expected complexity level and risk
Complexity 1.
Testing