Fix TypeScript imports codegen #2747
Merged
+322
−322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Cobo <[email protected]>
|
|
toqueteos
changed the title
toqueteos
changed the title
jsdt
approved these changes
May 21, 2025
Merged
via the queue into
clockworklabs:master
with commit May 21, 2025
c39bb46
14 of 15 checks passed
|
Thanks @jsdt ! There's also a change in docs related to this PR in clockworklabs/spacetime-docs#349 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The TypeScript Quickstart does not work out of the box because of imports using mixed types and non-types (classes and functions, not sure if enums also count) in the same line.
This change fixes that.
Huge thanks to this Discord message.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
N/A
There's probably a nicer way of fixing this long-term but I'm not aware of it.
I also sent this other PR clockworklabs/spacetime-docs#349 which fixes the remaining code that makes TypeScript Quickstart not work.