Skip to content

Fix TypeScript imports codegen #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

Fix TypeScript imports codegen #2747

merged 3 commits into from
May 21, 2025

Conversation

toqueteos
Copy link
Contributor

@toqueteos toqueteos commented May 16, 2025

Description of Changes

The TypeScript Quickstart does not work out of the box because of imports using mixed types and non-types (classes and functions, not sure if enums also count) in the same line.

This change fixes that.

Huge thanks to this Discord message.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

N/A


There's probably a nicer way of fixing this long-term but I'm not aware of it.

I also sent this other PR clockworklabs/spacetime-docs#349 which fixes the remaining code that makes TypeScript Quickstart not work.

@CLAassistant
Copy link

CLAassistant commented May 16, 2025

CLA assistant check
All committers have signed the CLA.

@toqueteos toqueteos changed the title codegen: add type modifier to mixed typescript imports Fix Typescript imports codegen May 16, 2025
@toqueteos toqueteos changed the title Fix Typescript imports codegen Fix TypeScript imports codegen May 16, 2025
@bfops bfops requested a review from jsdt May 20, 2025 22:34
Copy link
Contributor

@jsdt jsdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

FYI, I pushed a change to update the code snapshots in our unit tests, so this should be good to go.

@jsdt jsdt added this pull request to the merge queue May 21, 2025
Merged via the queue into clockworklabs:master with commit c39bb46 May 21, 2025
14 of 15 checks passed
@toqueteos toqueteos deleted the patch-1 branch May 22, 2025 17:42
@toqueteos
Copy link
Contributor Author

Thanks @jsdt ! There's also a change in docs related to this PR in clockworklabs/spacetime-docs#349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants