Freeze pnpm lockfile everywhere#5022
Draft
bfops wants to merge 8 commits into
Draft
Conversation
bfops
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
We believe that this smoketest could lead to vulnerabilities given all the recent npm supply chain attacks. We want everything to use our frozen lockfiles so nobody and nothing is installing arbitrary packages.
Most of these sites were actually frozen in CI due to that being the default in CI, but I thought it would be good to make it explicit anyway (and that also aligns the behavior between CI and local machines).
We added a lot of lockfiles to make this happen.
To refresh a template's lockfile:
To refresh the test fixture lockfile:
API and ABI breaking changes
Expected complexity level and risk
Testing