table_name: use Arc<str> #774
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
commented
Jan 28, 2024
| @@ -30,7 +30,7 @@ pub struct TxRecord { | |||
| /// The table that was modified. | |||
| pub(crate) table_id: TableId, | |||
| /// The table that was modified. | |||
| pub(crate) table_name: String, | |||
| pub(crate) table_name: Arc<str>, | |||
There was a problem hiding this comment.
This was the impetus for making that change. It seemed to me wasteful to clone the string when we very rarely need to change it. So we can just clone a reference count instead.
Centril
force-pushed
the
centril/table-name-arc
branch
from
2c47521 to
5de2971
Compare
cloutiertyler
previously approved these changes
Jan 28, 2024
Centril
dismissed
cloutiertyler’s stale review
Ran the generic benchmark numbers; many benchmarks are a wash; some regressions, some improvements, but I'm not yet satisfied.
|
This isn't yet a clear win; so let's hold off on merging. We might want to consider one of: |
|
Also, I think instead is the whole |
|
Because now |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Switches most cases where a table / reducer name is stored to an
Arc<str>rather thanString.API and ABI breaking changes
None
Expected complexity level and risk
1