Skip to content

Rename module to database where appropriate #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tamaro-skaljic
Copy link
Contributor

@tamaro-skaljic tamaro-skaljic commented Mar 27, 2025

I recommend reviewing commit by commit.

I'm not sure about 20b2e7b and 6aa5d9c, you can revert them if it's wrong.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is definitely an improvement. I've left some required suggestions before I can approve this.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM!

@tamaro-skaljic
Copy link
Contributor Author

When will this be merged?

@cloutiertyler cloutiertyler merged commit 17ee47d into clockworklabs:master Apr 16, 2025
@tamaro-skaljic tamaro-skaljic deleted the rename-module-to-database branch April 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants