gh-563: Add Pcb support for Cl computations in massive neutrino cosmologies - #564
Open
matteobaratto wants to merge 4 commits into
Open
gh-563: Add Pcb support for Cl computations in massive neutrino cosmologies#564matteobaratto wants to merge 4 commits into
matteobaratto wants to merge 4 commits into
Conversation
| isinstance(self.tracer2, PositionsTracer) | ||
| and getattr(self.tracer2, "use_Pcb", False) | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
Any chance we could jaxify this @matteobaratto @marcobonici ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Checklist
✅ Summary
The
Pcbmatter power spectrum has already been implemented in the library. However, the Cl computation pipeline currently always uses the total matter power spectrum (Pmm) and does not expose the possibility of selecting an alternative power spectrum.Some applications, such as cosmological analyses including massive neutrinos, require different choices of matter power spectrum depending on the observable. For example, galaxy clustering may require the use of the cold dark matter + baryon power spectrum (
Pcb), while galaxy-galaxy lensing may require a combination such assqrt(Pmm * Pcb).🔄 Changes
use_Pcbflag insidePositionTracerPcbinsisdeAngularPowerSpectrum🛠 How to Test
📝 Documentation
🏗 Related Issues
Resolves #563
📸 Screenshots (if applicable)
📌 Additional Notes
✅ PR Checklist for Developers
pre-commit run --all-filescloelib/docs/✅ PR Checklist for Reviewers
playgroundwill be updated in a corresponding follow-up PRREADME.mdfilecloelib/docs/)