Skip to content

gh-122: added alpha_s to cloelike - #123

Open
ivansladoljev wants to merge 3 commits into
mainfrom
adding_running_of_ns
Open

gh-122: added alpha_s to cloelike#123
ivansladoljev wants to merge 3 commits into
mainfrom
adding_running_of_ns

Conversation

@ivansladoljev

@ivansladoljev ivansladoljev commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

🚀 Pull Request Checklist

✅ Summary

Adds support for the running of the scalar spectral index (alpha_s = d n_s / d ln k) in CAMBBackground and propagates it through all cloelike likelihoods.

🔄 Changes

  • EuclidLikelihood_photo_Cls.py, EuclidLikelihood_photo_2pcf.py: added "alpha_s" to the parameter key list forwarded to Background
  • EuclidLikelihood_GCspectro_Pls.py, EuclidLikelihood_BAO.py: added alpha_s=parameters["alpha_s"] to Background(...) calls

🛠 How to Test

alpha_s defaults to 0.0 so all existing sampling scripts remain valid without modification. Scripts that want to vary it simply need to include alpha_s in their parameter dictionary and prior.

📝 Documentation

  • This PR updates documentation
  • This PR does not require documentation changes
  • Issue created for documentation update: Don't forget to link the task!

🏗 Related Issues

📌 Additional Notes

Complements the similar PR in cloelib


✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes
  • I have added tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that there are no No newline at the end of file warnings
  • Check that any added folder/file has been added to the README.md file
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@ivansladoljev ivansladoljev changed the title added alpha_s to cloelib gh-122: added alpha_s to cloelib Apr 21, 2026
@ivansladoljev ivansladoljev added enhancement New feature or request theory issues related with dealing with the theory vectors labels Apr 21, 2026
@ivansladoljev ivansladoljev changed the title gh-122: added alpha_s to cloelib gh-122: added alpha_s to cloelike Apr 21, 2026
@ivansladoljev
ivansladoljev force-pushed the adding_running_of_ns branch 2 times, most recently from 90d36b8 to 54d1c13 Compare May 12, 2026 10:12
@ivansladoljev
ivansladoljev force-pushed the adding_running_of_ns branch from 54d1c13 to 24bbdd2 Compare May 27, 2026 09:37
@gcanasherrera

Copy link
Copy Markdown
Member

Hi @ivansladoljev I was coming back to this. Could you solve the conflicts?

@gcanasherrera

Copy link
Copy Markdown
Member

@raphkou when @ivansladoljev fixes the conflicts, you can also proceed with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maintenance theory issues related with dealing with the theory vectors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CAMBBackground does not support running of the spectral index (alpha_s)

2 participants