Remove features that relied on printed exception parsing#3793
Merged
alexander-yakushev merged 1 commit intomasterfrom Mar 26, 2025
Merged
Remove features that relied on printed exception parsing#3793alexander-yakushev merged 1 commit intomasterfrom
alexander-yakushev merged 1 commit intomasterfrom
Conversation
66feaa2 to
cf279ad
Compare
bbatsov
reviewed
Mar 21, 2025
| ((and (member "done" status) causes) | ||
| (cider-stacktrace--analyze-render causes))))))))) | ||
|
|
||
| (defun cider-stacktrace-analyze-at-point () |
Member
There was a problem hiding this comment.
I think it's good to replace these obsolete commands with some message explaining why there were removed. I don't think they had many users, being relatively new, but adding a message like "Use x instead" is never a bad idea IMO.
Member
Author
There was a problem hiding this comment.
Good point! Will do.
bbatsov
approved these changes
Mar 21, 2025
Member
bbatsov
left a comment
There was a problem hiding this comment.
Looks good to me, sans my small remark that it might be a good idea to convert the remove interactive commands to just a message saying that users are supposed to use something else instead. (before we fully remove them a few releases down the road) You can also gut them and use make-obsolete https://www.gnu.org/software/emacs/manual/html_node/elisp/Obsolete-Functions.html
7f18e06 to
6b864a7
Compare
6b864a7 to
ebc50b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes features that depended on the now removed
analyze-stacktraceop which used Haystack parsing functionality:cider-stacktrace-analyze-stringandcider-stacktrace-analyze-at-pointfunctions.To replace this functionality, the latest cider-nrepl now provides much better ability to jump to functions and methods printed in the stacktrace (see clojure-emacs/orchard#320). I went through examples/tests in Haystack repository, and the improved Orchard can jump to most of them directly from any buffer, including REPL, e.g.: