Skip to content

Include test templates in sdist tarball#30

Merged
clokep merged 3 commits intoclokep:mainfrom
Natureshadow:patch-1
May 12, 2025
Merged

Include test templates in sdist tarball#30
clokep merged 3 commits intoclokep:mainfrom
Natureshadow:patch-1

Conversation

@Natureshadow
Copy link
Contributor

Please include these templates and release a new (post) release to PyPI.

This is important to be able to reproducibly run the test suite in the Debian package.

@clokep clokep self-requested a review October 1, 2021 16:47
@clokep
Copy link
Owner

clokep commented Oct 19, 2021

While testing this I ended up with the tests directory installed into site-packages, which is generally unwanted.

This seems to match what Django has in their MANIFEST.in, but I don't seem to end up with their tests in site-packages -- maybe there's a missing config somewhere to control that?

@clokep clokep removed their request for review October 19, 2021 12:19
@ghost
Copy link

ghost commented Nov 15, 2022

I tried to rebase this branch on top of main and ran pyproject-build .. It correctly includes the tests folder in the sdist and not in the wheel.

@clokep clokep self-requested a review November 15, 2022 20:23
@clokep
Copy link
Owner

clokep commented Jun 28, 2024

While testing this I ended up with the tests directory installed into site-packages, which is generally unwanted.

Do you have any response to this? Is there updated guidance saying this is a good idea?

@clokep clokep removed their request for review June 28, 2024 18:04
@clokep
Copy link
Owner

clokep commented May 12, 2025

Closing due to lack of response.

@clokep clokep closed this May 12, 2025
@Natureshadow
Copy link
Contributor Author

Natureshadow commented May 12, 2025 via email

@clokep
Copy link
Owner

clokep commented May 12, 2025

Look, that I didn't find the time to do your homework does not mean this issue doesn't exist anymore. Please re-open.

I'd encourage you to act more politely. Most folks maintaining open source packages aren't being paid to do so. Kind words can go a long way.

I never said the issue does not exist anymore, just that the solution was unclear. I wasn't able to reproduce the issue with tests being added to site-packages though. Maybe something got fixed in pip at some point or #37 to use build fixed it? 🤷

Anyway, this needs a couple more changes.

@clokep clokep reopened this May 12, 2025
@clokep clokep self-requested a review as a code owner May 12, 2025 19:50
@clokep clokep merged commit ab0243c into clokep:main May 12, 2025
6 checks passed
clokep added a commit that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants